[Platform][Agent] Rework Platform API to invoke and result #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
changed the title
chr-hertel
added
Platform
|
Where is the added line? 😄 |
Wouldn't it take away the fun of reviewing if I'd tell you right away? 😂 |
OskarStark
reviewed
Jul 18, 2025
Comment on lines
20
to
23
| #[CoversClass(StreamResult::class)] | ||
| #[Small] | ||
| final class StreamResponseTest extends TestCase | ||
| { |
There was a problem hiding this comment.
noo, please don't review - it's incomplete
chr-hertel
force-pushed
the
refactor-rename-response-result
branch
3 times, most recently
from
2386a51 to
8584c5f
Compare
chr-hertel
force-pushed
the
refactor-rename-response-result
branch
from
8584c5f to
9f0eec0
Compare
|
Merging in alignment with Oskar without approvals - not great to review anyways, sorry 😬 😇 |
Closed
chr-hertel
added a commit
that referenced
this pull request
Jul 20, 2025
This PR was merged into the main branch. Discussion ---------- [AIBundle] Fix dependency injection | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | License | MIT Fix DI config after #163 / #154. Should've rebased before merge – now we're getting a bunch of errors on `main`: ``` Symfony\AI\Agent\Toolbox\Toolbox::__construct(): Argument #1 ($tools) must be of type Traversable|array, Symfony\AI\Agent\Toolbox\ToolFactory\ReflectionToolFactory given ``` etc Commits ------- 3c6290e [AIBundle] Fix dependency injection config after #163
chr-hertel
added a commit
that referenced
this pull request
Jul 27, 2025
…ts (chr-hertel) This PR was merged into the main branch. Discussion ---------- [Platform] Renamed some Response leftovers in Platform tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | | License | MIT Follow up on #154 Commits ------- 43c44ca Renamed some Response leftovers in Platform tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can change the naming later, they said. PhpStorm has great tooling for that, they said. 😆 🙈
I skipped the ResponseFactory for now - not sure about the Agent vs Platform API and differences here.